Fix the password parsing issue #38

ramya-bangera · 2024-10-09T07:24:16Z

Escaping an already escaped password is causing the migrate container to error out with the following error.

 k -n discovery-service logs ds-td-snow-mig-up-8088-38-80-113830-wgqrq
Defaulted container "migration" out of: migration, migration-source (init), migration-check (init)
{"level":"info","msg":"error: pq: password authentication failed for user \"discovery_service_user\"","time":"2024-10-08T11:46:45Z"}

Added the fix to Queryescape user and password only if it is not already escaped.

Queryescape user and password only if it is not already escaped.

kd7lxl · 2024-10-14T15:34:42Z

internal/cli/main_test.go

+			input:    "hello%20world",
+			expected: "hello%20world",


The flaw with this approach is a set of characters in a password like %20 would not be interpreted correctly.

kd7lxl · 2024-10-14T15:37:12Z

internal/cli/main.go

@@ -67,10 +67,20 @@ func printUsageAndExit() {

 func dbMakeConnectionString(driver, user, password, address, name, ssl string) string {
 	return fmt.Sprintf("%s://%s:%s@%s/%s?sslmode=%s",


Consider using URL.String() to assemble this string. It will apply the required escaping. url.UserPassword() will encapsulate the username and password.

ramya-bangera added 2 commits October 10, 2024 12:52

Fix the password parsing issue

ffcbc82

Queryescape user and password only if it is not already escaped.

Add unit test

d2aeaa1

ramya-bangera force-pushed the ib-fix-pwd-escape branch from 8bf181b to d2aeaa1 Compare October 10, 2024 07:30

kd7lxl reviewed Oct 14, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix the password parsing issue #38

Fix the password parsing issue #38

ramya-bangera commented Oct 9, 2024

kd7lxl Oct 14, 2024

kd7lxl Oct 14, 2024

		@@ -67,10 +67,20 @@ func printUsageAndExit() {

		func dbMakeConnectionString(driver, user, password, address, name, ssl string) string {
		return fmt.Sprintf("%s://%s:%s@%s/%s?sslmode=%s",

Fix the password parsing issue #38

Are you sure you want to change the base?

Fix the password parsing issue #38

Conversation

ramya-bangera commented Oct 9, 2024

kd7lxl Oct 14, 2024

Choose a reason for hiding this comment

kd7lxl Oct 14, 2024

Choose a reason for hiding this comment